[ovs-dev] [PATCH v2] ofproto-dpif-upcall: Don't purge ukeys while in a quiescent state.

Ben Pfaff blp at ovn.org
Tue Nov 6 15:22:10 UTC 2018


On Tue, Nov 06, 2018 at 04:27:04PM +0300, Ilya Maximets wrote:
> On 02.11.2018 21:25, Ben Pfaff wrote:
> > revalidator_purge() iterates and modifies umap->cmap. This should
> > not happen in quiescent state, because cmap implementation based
> > on rcu protected variables. Let's narrow the quiescent period
> > to avoid possible wrong memory accesses.
> > 
> > CC: Joe Stringer <joe at ovn.org>
> > Fixes: 9fce0584a643 ("revalidator: Use 'cmap' for storing ukeys.")
> > Reported-by: Ilya Maximets <i.maximets at samsung.com>
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> >  ofproto/ofproto-dpif-upcall.c | 38 ++++++++++++++++----------------------
> >  1 file changed, 16 insertions(+), 22 deletions(-)
> > 
> 
> Thanks,
> 
> Acked-by: Ilya Maximets <i.maximets at samsung.com>

Thanks, applied to master.


More information about the dev mailing list