[ovs-dev] [PATCH] ipsec: Use @PYTHON@ directly instead of "/usr/bin/env python"
Ben Pfaff
blp at ovn.org
Sat Nov 10 16:27:08 UTC 2018
On Sat, Nov 10, 2018 at 04:29:07PM +0100, Timothy Redaelli wrote:
> Using "/usr/bin/env" is against Fedora Packaging Guidelines [1].
>
> Moreover, in this specific case, it also prevent "make rpm-fedora" to
> successfully complete on "Fedora Rawhide" since "#!/usr/bin/env python"
> must not be used anymore [2].
>
> [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_lines
> [2] https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error
>
> CC: Qiuyu Xiao <qiuyu.xiao.qyx at gmail.com>
> Fixes: 22c5eafb6efa ("ipsec: reintroduce IPsec support for tunneling")
> Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
Thanks. I had to fold the following in to make it work when the build
directory is not the same as the source directory. I applied it to
master.
diff --git a/configure.ac b/configure.ac
index 2b3800310231..bb726f89e251 100644
--- a/configure.ac
+++ b/configure.ac
@@ -208,6 +208,7 @@ AC_CONFIG_COMMANDS([include/openflow/openflow.h.stamp])
AC_CONFIG_COMMANDS([utilities/bugtool/dummy], [:])
AC_CONFIG_COMMANDS([ovn/dummy], [:])
AC_CONFIG_COMMANDS([ovn/utilities/dummy], [:])
+AC_CONFIG_COMMANDS([ipsec/dummy], [:])
m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES])
More information about the dev
mailing list