[ovs-dev] [ovs-dev, dpdk-latest, v1] netdev-dpdk: Upgrade to dpdk v18.11

Ilya Maximets i.maximets at samsung.com
Thu Nov 15 07:07:08 UTC 2018


Hmm.
Kevin already has a patch-set with the same purpose:
    https://patchwork.ozlabs.org/project/openvswitch/list/?series=75100

This patch-set already has some review comments. You can make your
comments too.

Anyway, Kevin, Ophir, you need to synchronize somehow in order to stop
duplicating each other's work and to not force reviewers to notice same
things twice.

P.S. Ophir, It'll be nice if you could add involved people to CC list
     while sending patches.

Best regards, Ilya Maximets.

On 15.11.2018 1:08, Ophir Munk wrote:
> 1. Enable compilation and linkage with dpdk 18.11.x
> 
> 2. Update references to DPDK version 18.11 in Documentation and in
> travis linux-build script
> 
> 3. Replace deprecated functions calls
>     - rte_eth_dev_attach
>     - rte_eth_dev_detach
> with their respective new calls
>     - rte_dev_probe
>     - rte_dev_remove
> 
> 4. Dpdk port representors were introduced in dpdk 18.xx.
> Commits examples are listed in [1]. dpdk representors
> documentation appears in [2]. A sample configuration which uses two
> representors ports (the output of "ovs-vsctl show" command) is
> shown in [3].
> 
> OVS remains backward compatible in supporting dpdk legacy PCI
> ports which do not include representors.
> 
> 5. Starting from dpdk 18.xx there is no more one to one relationship
> between an rte device (e.g. PCI bus) and an eth device (seen as dpdk
> port ids by OVS).
> The relationship became one (rte device) to many (eth devices).
> For example in [3] there are two devices (representors) using
> the same PCI address 0000:08:00.0.
> This commit handles the new one to many relationship. For example,
> when one of the devices representors is closed - the PCI bus cannot
> be detached until the other device is closed as well.
> 
> 6. HW offload capability DEV_RX_OFFLOAD_CRC_STRIP was replaced with
> DEV_RX_OFFLOAD_KEEP_CRC.
> 
> [1]
> e0cb96204b71 ("net/i40e: add support for representor ports")
> cf80ba6e2038 ("net/ixgbe: add support for representor ports")
> 26c08b979d26 ("net/mlx5: add port representor awareness")
> 
> [2]
> doc/guides/prog_guide/switch_representation.rst
> 
> [3]
> Bridge "ovs_br0"
>     Port "ovs_br0"
>         Interface "ovs_br0"
>             type: internal
>     Port "port-rep3"
>         Interface "port-rep3"
>             type: dpdk
>             options: {dpdk-devargs="0000:08:00.0,representor=[3]"}
>     Port "port-rep5"
>         Interface "port-rep5"
>             type: dpdk
>             options: {dpdk-devargs="0000:08:00.0,representor=[5]"}
>     ovs_version: "2.10.90"
> 
> Signed-off-by: Ophir Munk <ophirmu at mellanox.com>
> ---
> v1:
> Initial version (resent with [dpdk-latest PATCH v1])
> 
>  .travis/linux-build.sh                   |   2 +-
>  Documentation/intro/install/dpdk.rst     |  12 ++--
>  Documentation/topics/dpdk/vhost-user.rst |   6 +-
>  lib/netdev-dpdk.c                        | 111 ++++++++++++++++++++++---------
>  4 files changed, 91 insertions(+), 40 deletions(-)
> 


More information about the dev mailing list