[ovs-dev] [PATCH] dpif-netlink: Fix error behavior in dpif_netlink_port_add__().
Ben Pfaff
blp at ovn.org
Thu Nov 15 17:08:18 UTC 2018
Until now, the code here would report an error to its caller as success.
This fixes the problem.
Found by inspection.
Signed-off-by: Ben Pfaff <blp at ovn.org>
---
lib/dpif-netlink.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index f2011f22e548..7f6a6cc59592 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -716,7 +716,8 @@ dpif_netlink_port_add__(struct dpif_netlink *dpif, const char *name,
int error = 0;
if (dpif->handlers) {
- if (nl_sock_create(NETLINK_GENERIC, &socksp)) {
+ error = nl_sock_create(NETLINK_GENERIC, &socksp);
+ if (error) {
return error;
}
}
--
2.16.1
More information about the dev
mailing list