[ovs-dev] [PATCH dpdk-latest] tests: Ignore IOPL call failure.

[Timothy Redaelli]

On Fri, 23 Nov 2018 17:48:41 +0300
Ilya Maximets <i.maximets at samsung.com> wrote:

> On 23.11.2018 17:34, David Marchand wrote:
> > Hello Ilya,
> > 
> > On Fri, Nov 23, 2018 at 3:22 PM Ilya Maximets <i.maximets at samsung.com <mailto:i.maximets at samsung.com>> wrote:
> > 
> >     On 23.11.2018 16:41, Kevin Traynor wrote:  
> >     > On 11/23/2018 01:17 PM, Ilya Maximets wrote:  
> >     >> While running without required capabilities, i.e. as a non-root
> >     >> user, virtio pmd driver always fails to register itself producing
> >     >> an error message even if DPDK not enabled.
> >     >> Tests should ignore this to work correctly.
> >     >>
> >     >> At least required for DPDK 18.11.
> >     >>  
> >     >
> >     > Thanks Ilya.
> >     >
> >     > Acked-by: Kevin Traynor <ktraynor at redhat.com <mailto:ktraynor at redhat.com>>  
> > 
> >     Thanks Kevin.
> > 
> >     I've sent a patch to DPDK list to remove this error message,
> >     but I'm not sure if it could be accepted especially to 18.11.
> > 
> >     http://patches.dpdk.org/patch/48316/
> > 
> > 
> > I will look at your dpdk patch (too late for 18.11 from my pov).  
> 
> Thanks.
> 
> > 
> > I am just a bit surprised this is seen with 18.11.
> > This message has been here for quite some time, I suspect something changed in the logs but I did not find at a first glance.  
> 
> Same for me.
> Actually, I didn't test previous 18.* releases, but there was no such
> messages in 17.11. And this is a bit strange.

Hi,
unfortunately this patch doesn't work when you build OVS and DPDK as
shared libraries (the default on openvswitch-fedora.spec) since
libopenvswitch.so is linked with DPDK libraries and all OVS C tools are
linked with libopenvswitch.so.

This means the DPDK constructor (that prints the error) is called any
time you launch an OVS tool.

## ------------------------------- ##
## openvswitch 2.10.90 test suite. ##
## ------------------------------- ##
1. completion.at:21: testing appctl-bashcomp - basic verification ...
./completion.at:23: ovsdb-tool create conf.db $abs_top_srcdir/vswitchd/vswitch.ovsschema
--- /dev/null   2018-11-23 09:55:52.581343146 +0100
+++ /home/tredaell/dev/sources/ovs/tests/testsuite.dir/at-groups/1/stderr       2018-11-23 18:39:29.794323761 +0100
@@ -0,0 +1 @@
+rte_virtio_pmd_init(): IOPL call failed - cannot use virtio PMD
1. completion.at:21:  FAILED (completion.at:23)

(from make sandbox)
[tredaell at aldebaran tutorial]$ ovs-vsctl
rte_virtio_pmd_init(): IOPL call failed - cannot use virtio PMD
ovs-vsctl: missing command name (use --help for help)
[tredaell at aldebaran tutorial]$