[ovs-dev] [PATCH v2] expr: Properly initialize expr_constant

Ben Pfaff blp at ovn.org
Tue Oct 2 21:57:14 UTC 2018


On Tue, Oct 02, 2018 at 11:37:02AM -0700, Yifeng Sun wrote:
> expr_constant.masked may be uninitialized when its type is EXPR_C_STRING.
> This patch fixes this issue.
> 
> Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10731
> Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>

Thanks for working to fix the bugs reported by the fuzzer.

I don't understand this fix.  expr_constant is a union.  If an instance
has type EXPR_C_STRING, then its 'masked' member must not be accessed,
because that member is only relevant when it has type EXPR_C_INTEGER.

> v1->v2: Fix email subject by adding [ovs-dev]

I don't understand this either.  The mailing list itself adds [ovs-dev].

Thanks,

Ben.


More information about the dev mailing list