[ovs-dev] [PATCH v2 2/2] windows, ovn-nbctl: Add service_start call inside the server loop
Alin Gabriel Serdean
aserdean at ovn.org
Fri Oct 5 14:59:41 UTC 2018
> On 3 Oct 2018, at 01:37, Ben Pfaff <blp at ovn.org> wrote:
> On Tue, Oct 02, 2018 at 06:01:26PM +0300, Alin Gabriel Serdean wrote:
>> Currently all ovn-nbctl (daemon) tests are failing due to the missing
>> call to `service_start` which is required on Windows.
>> Windows lacks fork so we need to pass all arguments, so we can spawn a new
>> process and interpret it properly when calling `service_start`.
>> Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
>> Acked-by: Ben Pfaff <blp at ovn.org>
>> v2: Remove OVS_UNUSED, add acks
> I think that this can be made non-Windows specific by rewriting it as
> diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
> index eabd30308ac2..7e42b53a9079 100644
> --- a/ovn/utilities/ovn-nbctl.c
> +++ b/ovn/utilities/ovn-nbctl.c
Thanks for the suggestion and patch Ben. It looks cleaner and it passes the unit tests.
I sent a new version here:
Do you mind adding a sign off?
More information about the dev