[ovs-dev] [PATCH 2/2] ovn-nbctl: Don't parse table-formatting options in nbctl_client

[Numan Siddique]

On Sat, Oct 6, 2018 at 4:11 AM Mark Michelson <mmichels at redhat.com> wrote:

> When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse
> table formatting options. The problem is that this then removes the table
> formatting options from the array of options passed to the server loop. The
> server loop resets the table formatting options to the defaults and then
> attempts again to parse table formatting options. Unfortunately, they
> aren't
> present any longer. The result is that tables are always formatted with
> the default style.
>
> This patch solves the issue by not parsing the table formatting options
> in nbctl_client. Instead, the table formatting options are passed to the
> server loop and parsed there instead.
>
> Signed-off-by: Mark Michelson <mmichels at redhat.com>
>

Acked-by: Numan Siddique <nusiddiq at redhat.com>



> ---
>  ovn/utilities/ovn-nbctl.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
> index d65a9ba08..bff6d1380 100644
> --- a/ovn/utilities/ovn-nbctl.c
> +++ b/ovn/utilities/ovn-nbctl.c
> @@ -5443,7 +5443,6 @@ nbctl_client(const char *socket_name,
>              break;
>
>          VLOG_OPTION_HANDLERS
> -        TABLE_OPTION_HANDLERS(&table_style)
>
>          case OPT_LOCAL:
>          default:
> --
> 2.14.4
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>