[ovs-dev] [PATCH 2/2] ovn-nbctl: Don't parse table-formatting options in nbctl_client

Ben Pfaff blp at ovn.org
Mon Oct 8 15:33:53 UTC 2018


On Fri, Oct 05, 2018 at 06:40:34PM -0400, Mark Michelson wrote:
> When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse
> table formatting options. The problem is that this then removes the table
> formatting options from the array of options passed to the server loop. The
> server loop resets the table formatting options to the defaults and then
> attempts again to parse table formatting options. Unfortunately, they aren't
> present any longer. The result is that tables are always formatted with
> the default style.
> 
> This patch solves the issue by not parsing the table formatting options
> in nbctl_client. Instead, the table formatting options are passed to the
> server loop and parsed there instead.
> 
> Signed-off-by: Mark Michelson <mmichels at redhat.com>

This is a pretty subtle bug.  Would you mind adding a test to prevent
future regression?


More information about the dev mailing list