[ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

Ben Pfaff blp at ovn.org
Mon Oct 8 17:09:42 UTC 2018


On Fri, Oct 05, 2018 at 10:58:35AM +0100, Markos Chandras wrote:
> On 05/10/2018 09:55, Matteo Croce wrote:
> > On Fri, Oct 5, 2018 at 8:32 AM Markos Chandras <mchandras at suse.de> wrote:
> >>
> >> On 25/09/2018 22:14, Ben Pfaff wrote:
> >>>
> >>> Applied to master thanks!
> >>>
> >>> I sent a patch to remove support for multiple queues in the
> >>> infrastructure layer:
> >>>         https://patchwork.ozlabs.org/patch/974755/
> >>> _______________________________________________
> >>> dev mailing list
> >>> dev at openvswitch.org
> >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >>>
> >>
> >> Hello Ben and Matteo,
> >>
> >> This patch applies cleanly to branch-2.10, branch-2.9, and branch-2.8.
> >> Would it make sense to backport it to these as well?
> >>
> >> --
> >> markos
> >>
> >> SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
> >> HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
> > 
> > Hi Markos,
> > 
> > the file descriptor limit issue was first reported on OVS 2.8, so it's worth it.
> > If you backport it, please consider backporting the following commit from Ben,
> > which removes some code which become unused after my patch:
> > 
> > commit 769b50349f28c5f9e4bff102bc61dadcb9b99c37
> > Author: Ben Pfaff <blp at ovn.org>
> > Date:   Tue Sep 25 15:14:13 2018 -0700
> > 
> >     dpif: Remove support for multiple queues per port.
> > 
> > Regards,
> > 
> 
> Thank you Matteo,
> 
> Ben, please let me know if you can backport these up to branch-2.8
> otherwise I can send patches for each branch myself.

I backported:

69c51582ff78 ("dpif-netlink: don't allocate per thread netlink sockets")
to 2.10, 2.9, and 2.8.

769b50349f28 ("dpif: Remove support for multiple queues per port.")
to 2.10.  It got patch rejects on 2.9, so I skipped it there.  If you
want to fix it up and post a backport, please feel free.

dc2c9ce38748 ("ofproto-dpif-xlate.c: Fix uninitialized variable
warning.") to 2.10 because it fixes a warning introduce by 769b50349f28.

790a43722974 ("dpif-netlink: Fix null pointer.")  to 2.10, 2.9 and 2.8.


More information about the dev mailing list