[ovs-dev] [PATCH v4] ovn: Support configuring the BFD params for the tunnel interfaces
nusiddiq at redhat.com
Tue Oct 9 08:52:01 UTC 2018
On Mon, Oct 8, 2018 at 11:53 PM Ben Pfaff <blp at ovn.org> wrote:
> On Sat, Oct 06, 2018 at 08:04:09PM +0530, nusiddiq at redhat.com wrote:
> > From: Numan Siddique <nusiddiq at redhat.com>
> > With this commit the users can override the default values of
> > the BFD params - min_rx, min_tx, decay_min_rx and mult if desired.
> > This can be useful to debug any issues related to BFD (like
> > frequent BFD state changes).
> > A new column 'options' is added in NB_Global and SB_Global tables
> > of OVN_Northbound and OVN_Southbound schemas respectively. CMS
> > can define the options 'bfd:min-rx', 'bfd:min-tx',
> > 'bfd:decay-min-rx' and 'bfd:mult' in the options column of
> > NB_Global table row. ovn-northd copies these options from
> > NB_Global to SB_Global. ovn-controller configures these
> > options to the tunnel interfaces when enabling BFD.
> > Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
> Thank you for working to make OVN easier to debug and troubleshoot.
> Using : in the bfd option names makes it difficult to set them using
> ovn-nbctl. It is necessary to understand how to escape the :, as shown
> in the test, e.g.:
> ovn-nbctl --wait=hv set NB_Global . options:"bfd\:min-rx"=2000
> Do you think it would be a good idea to use - instead of : for this
Thanks for the review. I agree. I changed it to '-' in v6.
> When bfd_run() decides to disable bfd on an interface, it looks like it
> will still add any user-specified BFD settings. Is that intentional?
It was intentional. But I think it's better to clear the bfd column instead
of setting "enabled=false" and having the rest of the other bfd options.
I updated the patch and submitted v6 with this -
> The function interface_set_bfd() is now trivial, so it might make sense
> to inline it into the caller.
More information about the dev