[ovs-dev] [dpdk-howl PATCH v3] netdev-dpdk: Upgrade to dpdk v18.08

Ophir Munk ophirmu at mellanox.com
Wed Oct 10 16:41:33 UTC 2018


Hi Eelco,

1. v5 was sent. 

2. Regarding the deprecated functions warnings:

The deprecated DPDK functions are declared so in DPDK 18.08 but their actual replacement will only appear in DPDK 18.11.
Therefore I suggest to temporarily ignore the deprecated warnings till DPDK 18.11 is released at which time the OVS will be updated with the new function calls. 

3. FYI - There is an unexpected behavior with the OVS ML.
* Ilya's review did not reach my mail box (although it appears in the ML web site). This is probably why I initially skipped Ilay's comments.
* v4 that I sent a few days ago does not appear in the ML. Please consider it obsolete.

Starting from now I will check closely both my email and the ML to avoid further confusion.

Regards,
Ophir

> -----Original Message-----
> From: Eelco Chaudron [mailto:echaudro at redhat.com]
> Sent: Friday, September 21, 2018 4:02 PM
> To: Ophir Munk <ophirmu at mellanox.com>
> Cc: Ilya Maximets <i.maximets at samsung.com>; ovs-dev at openvswitch.org;
> Stokes, Ian <ian.stokes at intel.com>; Kevin Traynor <ktraynor at redhat.com>;
> Chandran, Sugesh <sugesh.chandran at intel.com>; Shahaf Shuler
> <shahafs at mellanox.com>; Asaf Penso <asafp at mellanox.com>; Thomas
> Monjalon <thomas at monjalon.net>
> Subject: Re: [ovs-dev] [dpdk-howl PATCH v3] netdev-dpdk: Upgrade to dpdk
> v18.08
> 
> Ophir,
> 
> Maybe a quick reply to the email with the review comments will clear things
> up. For example if and how you addressed them, etc. For example, did you
> take care of the deprecated DPDK functions, and if not why.
> Rather than only sending out the next version.
> 
> Will wait for the V5 before doing another review round...
> 
> //Eelco
> 
> On 21 Sep 2018, at 12:20, Ophir Munk wrote:
> 
> > Hi Ilya,
> > I apologize for skipping your last comments.
> > I will send v5 based on your review.
> >
> > Regards,
> > Ophir
> >
> >> -----Original Message-----
> >> From: Ilya Maximets [mailto:i.maximets at samsung.com]
> >> Sent: Thursday, September 20, 2018 4:17 PM
> >> To: ovs-dev at openvswitch.org; Ophir Munk <ophirmu at mellanox.com>
> >> Cc: Stokes, Ian <ian.stokes at intel.com>; Kevin Traynor
> >> <ktraynor at redhat.com>; Chandran, Sugesh
> <sugesh.chandran at intel.com>;
> >> Eelco Chaudron <echaudro at redhat.com>; Shahaf Shuler
> >> <shahafs at mellanox.com>; Asaf Penso <asafp at mellanox.com>; Thomas
> >> Monjalon <thomas at monjalon.net>
> >> Subject: Re: [ovs-dev] [dpdk-howl PATCH v3] netdev-dpdk: Upgrade to
> >> dpdk
> >> v18.08
> >>
> >> Hi Ophir,
> >> I see no significant code changes. At least there are no changes
> >> related to my comments for v2.
> >>
> >> Best regards, Ilya Maximets.
> >>
> >>> 1. Enable compilation and linkage with dpdk 18.08.0 The following
> >>> dpdk commits which were introduced after dpdk 17.11.x require OVS
> >>> updates to accommodate to the dpdk changes.
> >>> - ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> >>> - ab3ce1e0c193 ("ethdev: remove old offload API")
> >>> - c06ddf9698e0 ("meter: add configuration profile")
> >>> - e58638c32411 ("ethdev: fix TPID handling in flow API")
> >>> - cd8c7c7ce241 ("ethdev: replace bus specific struct with generic
> >>> dev")
> >>> - ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> >>>
> >>> 2. Limit configured rss hash functions to only those supported by
> >>> the eth device.
> >>>
> >>> 3. Update references to DPDK version 18.08 in Documentation
> >>>
> >>> 4. Update DPDK version 18.08 in travis' linux-build script
> >>>
> >>> Signed-off-by: Ophir Munk <ophirmu at mellanox.com>
> >>> ---
> >>> v1:
> >>> First version
> >>>
> >>> v2:
> >>> Avoid seg faults cases as described in
> >>>
> >>
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
> >> t
> >>>
> >>
> chwork.ozlabs.org%2Fpatch%2F965451%2F&amp;data=02%7C01%7Cophirm
> >> u%40mel
> >>>
> >>
> lanox.com%7C4644f155884f45c71a8b08d61efb2499%7Ca652971c7d2e4d9b
> >> a6a4d14
> >>>
> >>
> 9256f461b%7C0%7C0%7C636730461353548241&amp;sdata=Zlz3WXL%2Bh
> >> HlAXXLL6dC
> >>> 9AMeU1Yy9qfpIeNudsUPvCVw%3D&amp;reserved=0
> >>> by using the patch in:
> >>>
> >>
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
> >> t
> >>> hub.com%2Fkevintraynor%2Fovs-dpdk-
> >> master%2Fcommit%2F88f46cc5ab338eb4f3
> >>>
> >>
> ca5db1eacd0effefe4fa0c&amp;data=02%7C01%7Cophirmu%40mellanox.co
> >> m%7C464
> >>>
> >>
> 4f155884f45c71a8b08d61efb2499%7Ca652971c7d2e4d9ba6a4d149256f461
> >> b%7C0%7
> >>>
> >>
> C0%7C636730461353548241&amp;sdata=QcduhGev%2BSGSpKwb09y4j1I78
> >> uXboAVLt5
> >>> xzwv12ZQc%3D&amp;reserved=0
> >>>
> >>> v3:
> >>> - rebase on latest dpdk-hwol branch
> >>> - Updates based on latest reviews to versions v1 & v2
> >>>
> >>>  .travis/linux-build.sh                   |   2 +-
> >>>  Documentation/intro/install/dpdk.rst     |  14 +--
> >>>  Documentation/topics/dpdk/vhost-user.rst |   6 +-
> >>>  lib/netdev-dpdk.c                        | 143
> >>> ++++++++++++++++++++++---------
> >>>  4 files changed, 114 insertions(+), 51 deletions(-)


More information about the dev mailing list