[ovs-dev] [ovs-dev, dpdk-howl, v2] netdev-dpdk: Upgrade to dpdk v18.08.0

Ophir Munk ophirmu at mellanox.com
Wed Oct 10 17:02:28 UTC 2018


Hi Ian,
Regarding your comment - I have sent patch https://patchwork.ozlabs.org/patch/981980/

Regards,
Ophir

> -----Original Message-----
> From: Ian Stokes [mailto:ian.stokes at intel.com]
> Sent: Wednesday, September 12, 2018 12:18 AM
> To: Ilya Maximets <i.maximets at samsung.com>; Ophir Munk
> <ophirmu at mellanox.com>; ovs-dev at openvswitch.org
> Cc: Shahaf Shuler <shahafs at mellanox.com>; Asaf Penso
> <asafp at mellanox.com>; Thomas Monjalon <thomas at monjalon.net>; Kevin
> Traynor <ktraynor at redhat.com>
> Subject: Re: [ovs-dev,dpdk-howl,v2] netdev-dpdk: Upgrade to dpdk v18.08.0
> 
> >>       if (dev->mtu > ETHER_MTU) {
> >> -        rte_eth_dev_info_get(dev->port_id, &info);
> >>           if (strncmp(info.driver_name, "net_nfp", 7)) {
> >> -            conf.rxmode.enable_scatter = 1;
> >> +            conf.rxmode.offloads |= DEV_RX_OFFLOAD_SCATTER;
> 
> Above will break MTU support for i40e devices (and any other devices that
> do not have scatter listed in their offload capabilities).
> 
> DPDK seems to have implemented offload capabilities for more PMD drivers
> since 17.11 so I'm thinking we can remove the specific check against net_nfp
> altogether and check for support for scatter in device capabilities before
> setting it for the device. Something like below:
> 
>      if (dev->mtu > ETHER_MTU) {
>          if (info.rx_offload_capa & DEV_RX_OFFLOAD_SCATTER) {
>              conf.rxmode.offloads |= DEV_RX_OFFLOAD_SCATTER;
>          }
>      }
> 
> It would require confirmation/testing for other PMD devices however that
> they list supported offloads correctly for scatter if it's required for RX jumbo
> frames.
> 
> Ian


More information about the dev mailing list