[ovs-dev] [PATCH] Python: Build C JSON extension conditionally.

[Ben Pfaff]

On Mon, Oct 15, 2018 at 11:12:41AM -0700, Ben Pfaff wrote:
> On Mon, Oct 15, 2018 at 06:04:14PM +0100, Tiago Lam wrote:
> > Commit a7be68a ("Test the Python C JSON extension") enables the building
> > of the C JSON parser Python extension by default, which tries to link to
> > a shared library of libopenvswitch. On instalations where
> > "--enable-shared" is not specified, although the build ultimately
> > suceeds, it prints the following messages:
> > 
> >     /usr/bin/ld: ../ovs/ovs/lib/.libs/libopenvswitch.a(json.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
> >     ../ovs/ovs/lib/.libs/libopenvswitch.a: error adding symbols: Bad value
> >     collect2: error: ld returned 1 exit status
> > 
> >     ***************************************************************************
> > 
> >     WARNING: The C extension could not be compiled, speedups are not enabled.
> > 
> >     Failure information, if any, is above.
> > 
> >     Retrying the build without the C extension.
> > 
> >     ***************************************************************************
> > 
> > This pollutes the compilation logs and can cause some CIs to consider
> > the build as "FAILED", since words as "WARNING" and "error" will be
> > interpreted as such while parsing the logs.
> > 
> > Fixes: a7be68a ("Test the Python C JSON extension")
> > CC: Terry Wilson <twilson at redhat.com>
> > Signed-off-by: Tiago Lam <tiago.lam at intel.com>
> 
> Thanks, applied to master.

Actually, Ilya makes a lot of good points.  I pushed his revert instead.
Can you please follow up to his email?  It lists a lot of issues.  It
would still be great to add tests but it's better to do it right.