[ovs-dev] [PATCH] dpif-netdev.at: Add missing backslash.
Stokes, Ian
ian.stokes at intel.com
Thu Oct 18 11:28:51 UTC 2018
> Lines splitted without '\' and the second line is never executed.
>
LGTM and is in keeping with the format others tests defined. I'll add this as part of this week's pull request.
Ian
> Fixes: b10d46a60013 ("tests: Check dpif-netdev odp_actions consistency.")
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> ---
> tests/dpif-netdev.at | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at index
> fff395d56..378292dac 100644
> --- a/tests/dpif-netdev.at
> +++ b/tests/dpif-netdev.at
> @@ -110,8 +110,10 @@ DPIF_NETDEV_DUMMY_IFACE([dummy-pmd])
> m4_define([DPIF_NETDEV_MISS_FLOW_INSTALL],
> [AT_SETUP([dpif-netdev - miss upcall key matches flow_install - $1])
> OVS_VSWITCHD_START(
> - [add-port br0 p1 -- set interface p1 type=$1
> options:pstream=punix:$OVS_RUNDIR/p0.sock
> - set bridge br0 datapath-type=dummy other-config:datapath-id=1234
> fail-mode=secure], [], [],
> + [add-port br0 p1 \
> + -- set interface p1 type=$1
> options:pstream=punix:$OVS_RUNDIR/p0.sock \
> + -- set bridge br0 datapath-type=dummy \
> + other-config:datapath-id=1234
> + fail-mode=secure], [], [],
> [m4_if([$1], [dummy-pmd], [--dummy-numa="0,0,0,0,1,1,1,1"], [])])
> AT_CHECK([ovs-appctl vlog/set dpif:dbg dpif_netdev:dbg])
>
> @@ -150,8 +152,10 @@ DPIF_NETDEV_MISS_FLOW_INSTALL([dummy-pmd])
> m4_define([DPIF_NETDEV_MISS_FLOW_DUMP],
> [AT_SETUP([dpif-netdev - miss upcall key matches flow_dump - $1])
> OVS_VSWITCHD_START(
> - [add-port br0 p1 -- set interface p1 type=$1
> options:pstream=punix:$OVS_RUNDIR/p0.sock
> - set bridge br0 datapath-type=dummy other-config:datapath-id=1234
> fail-mode=secure], [], [],
> + [add-port br0 p1 \
> + -- set interface p1 type=$1
> options:pstream=punix:$OVS_RUNDIR/p0.sock \
> + -- set bridge br0 datapath-type=dummy \
> + other-config:datapath-id=1234
> + fail-mode=secure], [], [],
> [m4_if([$1], [dummy-pmd], [--dummy-numa="0,0,0,0,1,1,1,1"], [])])
> AT_CHECK([ovs-appctl upcall/disable-ufid], [0], [Datapath dumping
> tersely using UFID disabled ], [])
> --
> 2.17.1
More information about the dev
mailing list