[ovs-dev] [PATCH 0/2] Add support to offload GRE tunnels

Roi Dayan roid at mellanox.com
Mon Oct 22 09:00:26 UTC 2018



On 22/10/2018 10:53, Simon Horman wrote:
> 
> 
> On Mon, 22 Oct 2018 at 09:16, Roi Dayan <roid at mellanox.com <mailto:roid at mellanox.com>> wrote:
> 
> 
> 
>     On 14/10/2018 10:26, Roi Dayan wrote:
>     >
>     >
>     > On 12/10/2018 13:05, Simon Horman wrote:
>     >> On Thu, Oct 11, 2018 at 10:06:41AM +0300, Roi Dayan wrote:
>     >>> Hi,
>     >>>
>     >>> The first patch is to add support to offload to GRE tunnels using tc.
>     >>> THe second patch is to offload the tunnel csum option correctly.
>     >>
>     >> Thanks Roi,
>     >>
>     >> this looks good to me:
>     >>
>     >> Reviewed-by: Simon Horman <simon.horman at netronome.com <mailto:simon.horman at netronome.com>>
>     >>
>     >> Let me see if I can get master clean wrt travis-ci so I can test
>     >> your patchset there before applying.
>     >>
>     >
>     > Thanks
>     >
>     > we also tested using travis and noticed a test failure
>     > that reproduced on master branch.
>     > we didnt get a chance to deep dive and help there,
>     > but looks like our patches dont add more failures.
>     >
>     > travis log with our patches
>     > https://travis-ci.org/roidayan/ovs/builds/439526807 <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Froidayan%2Fovs%2Fbuilds%2F439526807&data=02%7C01%7Croid%40mellanox.com%7C578db29b055c4cc63bf808d637f3964a%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636757916684570941&sdata=m7MhMfygEqGFg1W47swYBkxFCgN8%2F1nxbpr%2FHQEbQLs%3D&reserved=0>
>     >
>     > travis log with master
>     > https://travis-ci.org/roidayan/ovs/builds/439523018 <https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Froidayan%2Fovs%2Fbuilds%2F439523018&data=02%7C01%7Croid%40mellanox.com%7C578db29b055c4cc63bf808d637f3964a%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636757916684570941&sdata=kJ5tv6DA3kyfpCd3D6ky2ZdidJdnpJZ%2FShovt3PAc1c%3D&reserved=0>
>     >
> 
> 
>     Hi Simon,
> 
>     I noticed the second patch in the series is merged but not the first.
> 
>     Thanks,
>     Roi
> 
> 
> Hi Roi,
> 
> I am a little confused.
> 
> In the master branch I see:
> 
> bafb398bf6df dpdk: Use DPDK 17.11.4 release.
> ...
> d9677a1f0eaf netdev-tc-offloads: TC csum option is not matched with tunnel configuration
> 5e63eaa969a3 netdev-vport: Make gre netdev type to use TC rules
> 

oh sorry. i had some filter when checked for commits and i missed it.
i thought i disabled my filters and checked again but i guess i didn't.

thanks again!
Roi


More information about the dev mailing list