[ovs-dev] [PATCH v1 0/3] Policy-based routing

Numan Siddique nusiddiq at redhat.com
Tue Oct 23 06:38:18 UTC 2018


On Tue, Oct 23, 2018 at 3:54 AM Mary Manohar <mary.manohar at nutanix.com>
wrote:

> This patch series implements policy-based routing.
> Policy-based routing (PBR) provides a mechanism to configure permit/deny
> and reroute policies on the router.
> Permit/deny policies are similar to OVN ACLs, but exist on the
> logical-router.
> Reroute policies are needed for service-insertion and service-chaining.
> Currently, we support only stateless policies.
>
> To achieve this, we introduced a new table in the ingress pipeline of the
> Logical-router.
> The new table is between the ‘IP Routing’ and the ‘ARP/ND resolution’
> table.
> This way, PBR can override routing decisions and provide a different
> next-hop.
>
> Mary Manohar (3):
>   [1/3]: Routing policies, add config in schema
>   [2/3] Routing policies, add routing-policies in ovn-nbctl
>   [3/3]: Routing policies, ovn-northd changes to handle routing policy
>     commands.
>
>  ovn/northd/ovn-northd.c   | 144 ++++++++++++++++++++++++++++++++--
>  ovn/ovn-nb.ovsschema      |  20 ++++-
>  ovn/ovn-nb.xml            |  63 +++++++++++++++
>  ovn/utilities/ovn-nbctl.c | 196
> ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/ovn-nbctl.at        |  47 +++++++++++
>  5 files changed, 463 insertions(+), 7 deletions(-)
>

Hi,

I didn't get a chance to look into this yet, but It would be helpful if the
commit messages are a bit more detailed.
Perhaps the details in the patch 0 can go in the commit messages.

I see a white space warning in patch 2.

.git/rebase-apply/patch:56: trailing whitespace.
    /* Check if same routing policy already exists.

Thanks
Numan


> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list