[ovs-dev] [PATCH 3/8] ofp-table: Ignore bits that have to change according to OpenFlow.

Justin Pettit jpettit at ovn.org
Tue Oct 23 21:56:52 UTC 2018


> On Aug 30, 2018, at 1:00 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> OpenFlow table feature replies contain a per-table bitmap that indicates
> which tables a flow can point to in goto_table actions.  OpenFlow requires
> that a table only be able to go to higher-numbered tables.  This means that
> a switch that is general as possible will always have different features
> for every table, since each one will have a different bitmap.  This makes
> the output of "ovs-ofctl dump-table-features" pretty long and ugly because
> it has about 250 entries like this:
> 
>  table %d:
>    metadata: match=0xffffffffffffffff write=0xffffffffffffffff
>    max_entries=%d
>    instructions (table miss and others):
>      next tables: %d-253
>      (same instructions)
>      (same actions)
>    (same matching)
> 
> This commit changes the logic that prints table features messages so that
> it considers two sequentially numbered tables to be the same if only the
> bit that necessarily must be tunred off changes.  This reduces the hundreds
> of entries above to just:
> 
>   tables 1...253: ditto
> 
> which is so much more readable.
> 
> Signed-off-by: Ben Pfaff <blp at ovn.org>

Acked-by: Justin Pettit <jpettit at ovn.org>

--Justin




More information about the dev mailing list