[ovs-dev] [PATCH] ofp-msgs: Added ONF_ and NXT_REQUESTFORWARD for OF1.0-1.3

Ben Pfaff blp at ovn.org
Fri Oct 26 22:17:53 UTC 2018


On Fri, Oct 26, 2018 at 03:06:28PM -0700, Zak Whittington wrote:
> Backported OFPT14_REQUESTFORWARD to OF1.0-1.3.
> OF 1.0-1.2 use an NXT Nicira extension while OF 1.3
> uses an ONF extension (ONF version is specified in a
> previously published ONF spec sheet).
> 
> Includes ofp-print tests for multiple inner message
> types, and multiple OF versions including the NXT and ONF.
> Also includes more end-to-end ofproto tests for both
> NXT OF1.0 and also ONF OF1.3.
> 
> VMware-BZ: 2136594
> Signed-off-by: Zak Whittington <zwhitt.vmware at gmail.com>

Clang said:

    ../lib/ofp-monitor.c:817:24: error: implicit conversion from enumeration type 'enum ofpraw' to different enumeration type 'enum ofptype' [-Werror,-Wenum-conversion]
    ../lib/ofp-monitor.c:819:24: error: implicit conversion from enumeration type 'enum ofpraw' to different enumeration type 'enum ofptype' [-Werror,-Wenum-conversion]
    ../lib/ofp-monitor.c:821:24: error: implicit conversion from enumeration type 'enum ofpraw' to different enumeration type 'enum ofptype' [-Werror,-Wenum-conversion]
    ../lib/ofp-monitor.c:824:45: error: implicit conversion from enumeration type 'enum ofptype' to different enumeration type 'enum ofpraw' [-Werror,-Wenum-conversion]

so I changed the type of raw_msg_type from enum ofptype to enum ofpraw,
and applied this to master.

Thanks again!


More information about the dev mailing list