[ovs-dev] [PATCH] dpif-netlink: Don't destroy and recreate port if it exists

Ben Pfaff blp at ovn.org
Tue Oct 30 18:40:59 UTC 2018


On Mon, Oct 29, 2018 at 08:29:41AM +0000, Jianbo Liu wrote:
> In commit 7521e0cf9e ('ofproto-dpif: Let the dpif report when a port is
> a duplicate'), the checking of port existence before adding was removed,
> and it's up to the dpif to check if port exists and add only if needed.
> 
> But the port can't be added to datapath if already exists. Then it will
> be destroyed and created again. This causes problem because configuration
> may miss. For example, if creating two vxlan on the same port, its ingress
> qdisc will be lost after recreated.
> 
> Signed-off-by: Jianbo Liu <jianbol at mellanox.com>
> Reviewed-by: Roi Dayan <roid at mellanox.com>

Thanks for the fix.  I applied this to master and branch-2.10.


More information about the dev mailing list