[ovs-dev] [PATCH] ovs-lib.in: Remove unnecessary conntrack flush

Yi-Hung Wei yihung.wei at gmail.com
Tue Oct 30 20:47:25 UTC 2018


We introduced flush-conntrack in force-reload-kmod script by commit
8bea39b186ca ("datapath: Prevent panic") to prevent kernel panic.
It turns out that the kernel panic is actually triggered by the
IPv4 secret timer, and it is fixed by commit
121905984724 ("compat: Initialize IPv4 reassembly secret timer").

This commit removes the unnecessary conntrack flush in the script.

Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
CC: Greg Rose <gvrose8192 at gmail.com>
---
 utilities/ovs-lib.in | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/utilities/ovs-lib.in b/utilities/ovs-lib.in
index f6b539317a30..7df672c2c7bc 100644
--- a/utilities/ovs-lib.in
+++ b/utilities/ovs-lib.in
@@ -608,9 +608,6 @@ force_reload_kmod () {
     stop_ovsdb
     start_ovsdb || return 1
 
-    if [ -n "$(ovs-dpctl show)" ]; then
-        action "Flush old conntrack entries" ovs-appctl dpctl/flush-conntrack
-    fi
     stop_forwarding
 
     if action "Saving interface configuration" save_interfaces; then
-- 
2.7.4



More information about the dev mailing list