[ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters
sriharsha.basavapatna at broadcom.com
Wed Oct 31 03:31:59 UTC 2018
On Wed, Oct 31, 2018 at 3:33 AM Ben Pfaff <blp at ovn.org> wrote:
> On Mon, Oct 29, 2018 at 10:16:45AM +0530, Sriharsha Basavapatna via dev wrote:
> > A few lines with form feed characters (ASCII: ^L) were accidentally
> > deleted by a recent commit to support rebalancing of offloaded flows.
> > This patch reverts those lines.
> > Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows")
> > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com>
> Thanks for the patch.
> In the email headers, your name and email address show up as:
> From: Sriharsha Basavapatna via dev <ovs-dev at openvswitch.org>
> When this gets fed into Git, it ends up with "ovs-dev at openvswitch.org"
> credited with the patch, as well as "via dev" at the end of the name.
> That's not good. Can you send the patch from a "From" address that is
> appropriate for the commit?
I'd reported this problem to Aaron sometime back and the the email
thread is below; seems like some issues with patchwork.
> On Thu, Sep 13, 2018 at 7:50 PM, Aaron Conole <aconole at bytheb.org> wrote:
>> Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com> writes:
>>> I got this error below from 0-day robot. The patch contains my
>>> sign-off, so I'm not sure what the issue is here. Please take a look
>>> and let me know.
>> Thanks for the report!
> Thanks for your response.
>> I think what happened was you sent to ovs-dev at openvswitch.org and that
>> bounced the message to dev at openvswitch.org
> No; I just checked the git command that I issued; I did send it to
> dev at openvswitch.org:
> # git send-email --to dev at openvswitch.org *.patch
Okay - looking a bit closer, the mailing list has everything correct,
but patchwork lists your mail coming via some kind of bounce.
I'm lost at this point - I don't know how the mail gets routed from the
list to PW. But it doesn't look like you've done anything incorrectly.
More information about the dev