[ovs-dev] [PATCH] dpif: Restore a few lines with form feed characters

Ben Pfaff blp at ovn.org
Wed Oct 31 16:11:31 UTC 2018


On Wed, Oct 31, 2018 at 04:56:07PM +0530, Sriharsha Basavapatna wrote:
> On Wed, Oct 31, 2018 at 10:02 AM Ben Pfaff <blp at ovn.org> wrote:
> >
> > On Wed, Oct 31, 2018 at 09:01:59AM +0530, Sriharsha Basavapatna wrote:
> > > On Wed, Oct 31, 2018 at 3:33 AM Ben Pfaff <blp at ovn.org> wrote:
> > > >
> > > > On Mon, Oct 29, 2018 at 10:16:45AM +0530, Sriharsha Basavapatna via dev wrote:
> > > > > A few lines with form feed characters (ASCII: ^L) were accidentally
> > > > > deleted by a recent commit to support rebalancing of offloaded flows.
> > > > > This patch reverts those lines.
> > > > >
> > > > > Fixes: 57924fc91c ("revalidator: Rebalance offloaded flows")
> > > > > Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna at broadcom.com>
> > > >
> > > > Thanks for the patch.
> > > >
> > > > In the email headers, your name and email address show up as:
> > > >         From: Sriharsha Basavapatna via dev <ovs-dev at openvswitch.org>
> > > >
> > > > When this gets fed into Git, it ends up with "ovs-dev at openvswitch.org"
> > > > credited with the patch, as well as "via dev" at the end of the name.
> > > > That's not good.  Can you send the patch from a "From" address that is
> > > > appropriate for the commit?
> > > >
> > > > Thanks,
> > > >
> > > > Ben.
> > >
> > > Hi Ben,
> > >
> > > I'd reported this problem to Aaron sometime back and the the email
> > > thread is below; seems like some issues with patchwork.
> >
> > I didn't get the patch from patchwork but directly from the mailing
> > list, so it's not a problem with patchwork.
> >
> > (You'll notice that when I quoted your email, the leader said "Sriharsha
> > Basavapatna via dev wrote".  That's because it's literally the From:
> > line of the email that I replied to.)
> 
> Hi Ben,
> 
> Not sure how "via dev ..." is getting added. Do you want me to
> explicitly specify "from: " to git send-email on the command line ?
> Let me know if there's anything else you can think of.

Try it.


More information about the dev mailing list