[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

Jaime Caamaño Ruiz jcaamano at suse.de
Wed Oct 31 17:57:21 UTC 2018


First go at it

https://www.spinics.net/lists/netdev/msg531328.html

Changed the commit message to something a bit more verbose.

BR
Jaime.

-----Original Message-----
From: Gregory Rose <gvrose8192 at gmail.com>
To: Yi-Hung Wei <yihung.wei at gmail.com>
Cc: ovs dev <dev at openvswitch.org>, jcaamano at suse.de
Subject: Re: [ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet
validation
Date: Wed, 31 Oct 2018 10:10:18 -0700

On 10/31/2018 9:56 AM, Yi-Hung Wei wrote:
> On Wed, Oct 31, 2018 at 9:44 AM Gregory Rose <gvrose8192 at gmail.com>
> wrote:
> > On 10/31/2018 9:08 AM, Jaime Caamaño Ruiz wrote:
> > > When validating push/pop ethernet actions, mac_proto is not being
> > > reset
> > > correctly.
> > > 
> > > Reported-at:
> > > https://mail.openvswitch.org/pipermail/ovs-discuss/2018-October/0
> > > 47554.html
> > > Fixes: 6fcecb85ab ("datapath: add Ethernet push and pop actions")
> > > Signed-off-by: Jaime Caamaño Ruiz <jcaamano at suse.com>
> > > ---
> > 
> > Thanks for fixing up the tags Jaime.
> > 
> > Tested-by: Greg Rose <gvrose8192 at gmail.com>
> > Reviewed-by: Greg Rose <gvrose8192 at gmail.com>
> 
> Since this is a kernel datapath patch, maybe we shall first upstream
> it to net-next or in this case net (since it is a bug fix), then we
> backport it back to ovs.
> 
> http://docs.openvswitch.org/en/latest/internals/contributing/backport
> ing-patches
> 
> Thanks,
> 
> -Yi-Hung

I was going to do that but if Jaime is comfortable posting it to
netdev 
then that works.

- Greg



More information about the dev mailing list