[ovs-dev] [PATCH] datapath: Fix wrong push/pop ethernet validation

Ben Pfaff blp at ovn.org
Wed Oct 31 18:03:19 UTC 2018


On Wed, Oct 31, 2018 at 10:40:36AM -0700, Gregory Rose wrote:
> On 10/31/2018 10:32 AM, Ben Pfaff wrote:
> >On Wed, Oct 31, 2018 at 08:35:13AM -0700, Gregory Rose wrote:
> >>The order of tags should be:
> >>Reported-at:
> >>Fixes:
> >>Signed-off-by:
> >I agree that's the most common order but do we have anything that says
> >so?  (Should we?)
> 
> Uh - good point.  I don't know of anything that says so.  I've been told by
> maintainers on the Linux
> lists to reorder tags along those lines but I don't know of any official
> documentation that says it.
> 
> Should we?
> 
> I guess when I think about it I'd just want the Signed-off-by: line last. 
> But I suppose that's just my
> preference.

Well, if the Linux folks do it that way, we should too, to avoid
confusion.

I sent a patch:
        https://patchwork.ozlabs.org/patch/991629/


More information about the dev mailing list