[ovs-dev] [PATCH] submitting-patches: Advise not to wrap tags across multiple lines.

Gregory Rose gvrose8192 at gmail.com
Wed Oct 31 18:08:43 UTC 2018


On 10/31/2018 11:06 AM, Ben Pfaff wrote:
> It makes parsing them more difficult.
>
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
>   Documentation/internals/contributing/submitting-patches.rst | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/internals/contributing/submitting-patches.rst b/Documentation/internals/contributing/submitting-patches.rst
> index 1755c8a6691a..5a314cc60aa7 100644
> --- a/Documentation/internals/contributing/submitting-patches.rst
> +++ b/Documentation/internals/contributing/submitting-patches.rst
> @@ -145,6 +145,9 @@ The description ends with a series of tags, written one to a line as the last
>   paragraph of the email.  Each tag indicates some property of the patch in an
>   easily machine-parseable manner.
>   
> +Please don't wrap a tag across multiple lines.  If necessary, it's OK to have a
> +tag extend beyond the customary maximum width of a commit message.
> +
>   Examples of common tags follow.
>   
>   ``Signed-off-by: Author Name <author.name at email.address...>``

+1

Reviewed-by: Greg Rose <gvrose8192 at gmail.com>



More information about the dev mailing list