[ovs-dev] [PATCH] contributing: Signed-off-by tags should come last.

Gregory Rose gvrose8192 at gmail.com
Wed Oct 31 18:09:41 UTC 2018


On 10/31/2018 11:02 AM, Ben Pfaff wrote:
> Suggested-by: Gregory Rose <gvrose8192 at gmail.com>
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
>   Documentation/internals/contributing/submitting-patches.rst | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/internals/contributing/submitting-patches.rst b/Documentation/internals/contributing/submitting-patches.rst
> index 0ddd24502cc9..1755c8a6691a 100644
> --- a/Documentation/internals/contributing/submitting-patches.rst
> +++ b/Documentation/internals/contributing/submitting-patches.rst
> @@ -157,6 +157,12 @@ Examples of common tags follow.
>     If the author and submitter are different, each must sign off.  If the patch
>     has more than one author, all must sign off.
>   
> +  Signed-off-by tags should be the last tags in the commit message.  If the
> +  author (or authors) and submitter are different, the author tags should come
> +  first.  More generally, occasionally a patch might pass through a chain of
> +  submitters, and in such a case the sign-offs should be arranged in
> +  chronological order.
> +
>     ::
>   
>         Signed-off-by: Author Name <author.name at email.address...>

Sounds good to me!

Reviewed-by: Greg Rose <gvrose8192 at gmail.com>



More information about the dev mailing list