[ovs-dev] [PATCH] submitting-patches: Advise not to wrap tags across multiple lines.

Flavio Leitner fbl at sysclose.org
Wed Oct 31 18:32:07 UTC 2018


On Wed, Oct 31, 2018 at 11:06:50AM -0700, Ben Pfaff wrote:
> It makes parsing them more difficult.

It does, indeed.
Acked-by: Flavio Leitner <fbl at sysclose.org>

> 
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
>  Documentation/internals/contributing/submitting-patches.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/internals/contributing/submitting-patches.rst b/Documentation/internals/contributing/submitting-patches.rst
> index 1755c8a6691a..5a314cc60aa7 100644
> --- a/Documentation/internals/contributing/submitting-patches.rst
> +++ b/Documentation/internals/contributing/submitting-patches.rst
> @@ -145,6 +145,9 @@ The description ends with a series of tags, written one to a line as the last
>  paragraph of the email.  Each tag indicates some property of the patch in an
>  easily machine-parseable manner.
>  
> +Please don't wrap a tag across multiple lines.  If necessary, it's OK to have a
> +tag extend beyond the customary maximum width of a commit message.
> +
>  Examples of common tags follow.
>  
>  ``Signed-off-by: Author Name <author.name at email.address...>``
> -- 
> 2.16.1
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

-- 
Flavio



More information about the dev mailing list