[ovs-dev] [PATCH] daemon-unix: Use same name for original or restarted children.
Ben Pfaff
blp at ovn.org
Thu Sep 6 18:03:56 UTC 2018
On Thu, Sep 06, 2018 at 10:53:29AM -0700, Guru Shetty wrote:
> On Thu, 6 Sep 2018 at 10:45, Ben Pfaff <blp at ovn.org> wrote:
>
> > Linux has an idea of process name that is visible in /proc/$pid/comm. This
> > is "ovs-vswitchd" for a freshly started ovs-vswitchd process. When the
> > monitor code restarted a crash child, it changed it to the empty string.
> > This confused the daemon_is_running check in ovs-lib.in, which checks
> > comm. This commit fixes the problem by setting the program name as comm
> > in newly restarted children.
> >
> > VMware-BZ: #2191724
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> >
>
> Tested it. Looks right
> Acked-by: Gurucharan Shetty <guru at ovn.org>
Thanks. I applied this to master and backported as far as branch-2.4.
> (But I do see a bunch of unit test failures in branch-2.9 which is
> unrelated to this fix.)
I guess we should handle those separately.
More information about the dev
mailing list