[ovs-dev] [ovs-discuss] [PATCH] [PATCH] QinQ: support more vlan headers.

Lilijun (Jerry, Cloud Networking) jerry.lilijun at huawei.com
Fri Sep 7 06:17:05 UTC 2018


Sorry, I will push it again to fix this error.

-----Original Message-----
From: Ben Pfaff [mailto:blp at ovn.org] 
Sent: Friday, September 07, 2018 12:20 PM
To: Lilijun (Jerry, Cloud Networking) <jerry.lilijun at huawei.com>
Cc: ovs-discuss at openvswitch.org; dev at openvswitch.org; Eric Garver <e at erig.me>
Subject: Re: [ovs-discuss] [PATCH] [ovs-dev] [PATCH] QinQ: support more vlan headers.

On Fri, Sep 07, 2018 at 02:54:18AM +0000, Lilijun (Jerry, Cloud Networking) wrote:
> Hi all,
> 
> In my test, vlan-limit is set to 0 that means unlimited the count of 
> vlan headers.
> ovs-vsctl set Open_vSwitch . other_config:vlan-limit=0
> 
> But in fact the macro FLOW_MAX_VLAN_HEADERS is defined as 2, so we can 
> only support max two vlan headers. It doesn't work as the config 
> vlan-limit's description.
> 
> So, when VM sends a packet already with two vlan headers, the vport 
> configured with qinq mode can't add another s-vlan headers. 
> FLOW_MAX_VLAN_HEADERS need to be larger to support more vlan headers.

Doesn't apply.

When I apply it by hand, the build fails:

In file included from ../lib/cfm.c:26:
In file included from ../lib/dp-packet.h:32:
In file included from ../lib/flow.h:30:
../include/openvswitch/flow.h:167:1: error: static_assert failed "offsetof(struct flow, igmp_group_ip4) + sizeof(uint32_t) == sizeof(struct flow_tnl) + sizeof(struct ovs_key_nsh) + 300 && FLOW_WC_SEQ == 41"
../include/openvswitch/compiler.h:255:33: note: expanded from macro 'BUILD_ASSERT_DECL'


More information about the dev mailing list