[ovs-dev] [ovs-discuss] [PATCH] [PATCH] QinQ: support more vlan headers.

Lilijun (Jerry, Cloud Networking) jerry.lilijun at huawei.com
Fri Sep 7 09:58:16 UTC 2018


We can remove the unlimited words.  Maybe like this:

              Value  0  means  the max number of VLANs  supported  by  Open vSwitch userspace (currently 2), or the number
              supported by the datapath.

-----Original Message-----
From: Ben Pfaff [mailto:blp at ovn.org] 
Sent: Friday, September 07, 2018 12:13 PM
To: Lilijun (Jerry, Cloud Networking) <jerry.lilijun at huawei.com>
Cc: ovs-discuss at openvswitch.org; dev at openvswitch.org; Eric Garver <e at erig.me>
Subject: Re: [ovs-discuss] [PATCH] [ovs-dev] [PATCH] QinQ: support more vlan headers.

On Fri, Sep 07, 2018 at 02:51:25AM +0000, Lilijun (Jerry, Cloud Networking) wrote:
> In my test, vlan-limit is set to 0 that means unlimited the count of 
> vlan headers.
> ovs-vsctl set Open_vSwitch . other_config:vlan-limit=0
> 
> But in fact the macro FLOW_MAX_VLAN_HEADERS is defined as 2, so we can 
> only support max two vlan headers. It doesn't work as the config 
> vlan-limit's description.

The following is the description.  Please explain how it can be made clearer.

       other_config  :  vlan-limit: optional string, containing an integer, at
       least 0
              Limits the number of VLAN headers that can  be  matched  to  the
              specified  number.  Further VLAN headers will be treated as pay‐
              load, e.g. a packet with more 802.1q headers will match Ethernet
              type 0x8100.

              Value  0  means  unlimited.  The actual number of supported VLAN
              headers is the smallest of vlan-limit, the number of VLANs  sup‐
              ported  by  Open vSwitch userspace (currently 2), and the number
              supported by the datapath.

              If this value is absent, the default is currently 1. This  main‐
              tains backward compatibility with controllers that were designed
              for use with Open vSwitch versions earlier than 2.8, which  only
              supported one VLAN.


More information about the dev mailing list