[ovs-dev] [ovs-dev, v2] tests: Make test result more predictable.

Simon Horman simon.horman at netronome.com
Fri Sep 7 14:00:22 UTC 2018


On Fri, May 18, 2018 at 09:52:23AM -0700, Darrell Ball wrote:
> The test 'ofproto-dpif - in place modification (vlan)' fails often
> due to miss handling. Hence, make it more predictable by specifying
> that misses should just be dropped.
> 
> Signed-off-by: Darrell Ball <dlu998 at gmail.com>

This patch was applied to master and virtue of that is
present in branch-2.10. It also seems appropriate
for branch-2.8 and branch-2.9. Could we consider applying
it there too?

> ---
>  tests/ofproto-dpif.at | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
> index 60f28e2..635fbb4 100644
> --- a/tests/ofproto-dpif.at
> +++ b/tests/ofproto-dpif.at
> @@ -8974,7 +8974,8 @@ OVS_VSWITCHD_START(
>    [add-port br0 p1 -- set Interface p1 type=dummy ofport_request=1])
>  AT_CHECK([ovs-appctl vlog/set dpif:dbg dpif_netdev:dbg])
>  
> -AT_CHECK([ovs-ofctl del-flows br0])
> +# Always drop misses
> +AT_CHECK([ovs-ofctl -O OpenFlow11 mod-table br0 all drop])
>  AT_CHECK([ovs-ofctl add-flow br0 in_port=1,actions=output:local])
>  
>  ovs-appctl vlog/set PATTERN:ANY:'%c|%p|%m'


More information about the dev mailing list