[ovs-dev] [PATCH] datapath: stt: Remove unused if statement in function stt_cleanup().

Gregory Rose gvrose8192 at gmail.com
Fri Sep 7 16:40:30 UTC 2018


On 9/7/2018 3:21 AM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian at huawei.com>
>
> Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> ---
>   datapath/linux/compat/stt.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c
> index 8d16c1f..506f1d9 100644
> --- a/datapath/linux/compat/stt.c
> +++ b/datapath/linux/compat/stt.c
> @@ -1706,9 +1706,6 @@ static void stt_cleanup(struct net *net)
>   	int i;
>   
>   	sn->n_tunnels--;
> -	if (sn->n_tunnels)
> -		goto out;
> -out:
>   	n_tunnels--;
>   	if (n_tunnels)
>   		return;

It's always nice to snip out some dead code.  LGTM.

Reviewed-by:  Greg Rose <gvrose8192 at gmail.com>



More information about the dev mailing list