[ovs-dev] [PATCH v1] rhel: add build option to package ovs shared libraries, fedora

Ben Pfaff blp at ovn.org
Tue Sep 11 01:54:22 UTC 2018


On Mon, Sep 10, 2018 at 08:58:37PM -0300, Flavio Leitner wrote:
> On Mon, Sep 10, 2018 at 02:53:54PM -0700, Ben Pfaff wrote:
> > On Mon, Sep 10, 2018 at 06:46:51PM -0300, Flavio Leitner wrote:
> > > On Mon, Sep 10, 2018 at 01:33:31PM -0700, Martin Xu wrote:
> > > > This patches extends 4886d4d2495b (debian, rhel: Ship ovs shared
> > > > libraries and header files) to fedora, by adding support of
> > > > '--with enabled_shared' flag to 'make rpm-fedora' command.
> > > > By default, the shared libraries are not included in the openvswitch
> > > > RPM. When 'with' is specified, the openvswith RPM is packaged with the
> > > > shared library files. These files are always packaged for the RPM built
> > > > with rhel6 spec file.
> > > > 
> > > > VMware-BZ: #2036847
> > > 
> > > RPM-wise this patch looks good.  But once you shipped, other projects
> > > might use it and I believe that's exactly what you're looking for. 
> > > 
> > > However, I am not sure about the current situation with the libraries,
> > > so if we don't have a stable API/ABI or proper versioning, there might
> > > be unpleasant surprises for the users linking to them.
> > > 
> > > I'd say that if we are confident enough that the libraries are fine,
> > > then just package and ship them by default, and perhaps have an option
> > > to not to that. On the other hand, if we are not confident, then perhaps
> > > we need to work on that first before enable and ship them?
> > 
> > Our current policy for shared libraries is that they should be ABI
> > compatible within a given release (2.8.x, 2.9.x, etc.) but not
> > necessarily between releases.
> > 
> > Documentation/internals/contributing/libopenvswitch-abi.rst has details.
> 
> Ok, well, we are not rebasing in Fedora so that should be good enough.
> It's not the first time we have a request to ship the libraries, so
> I'd say to ship them by default.
> 
> What do you think?

Seems fine to me.  The corresponding Debian packaging includes a library
package.


More information about the dev mailing list