[ovs-dev] [PATCH] ovs-save: Don't always include the default flow during restore

[Guru Shetty]

On Tue, 11 Sep 2018 at 09:07, Flavio Leitner <fbl at sysclose.org> wrote:

> On Sun, Sep 09, 2018 at 02:20:02PM +0200, Timothy Redaelli wrote:
> > Currently the default flow (actions=NORMAL) is present in the flow table
> after
> > the flow table is restored also when the default flow is removed.
> >
> > This commit changes the behaviour of the "ovs-save save-flows" command
> to use
> > "replace-flows" instead of "add-flows" to restore the flows. This is
> needed in
> > order to always have the new flow table as it was before restoring it.
> >
> > Reported-by: Flavio Leitner <fbl at sysclose.org>
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1626096
> > Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
> > ---
>
> From the performance point of view, I thought we could do a
> del-flows first followed by add-flows, but you mentioned off
> list that the performance with replace-flows is still good.
>

Can you please provide some data. For e.g., with 200,000 flows.


>
> Patch looks good and works for me, thanks Timothy!
>
> Acked-by: Flavio Leitner <fbl at sysclose.org>
>
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>