[ovs-dev] [PATCH] ovs-save: Don't always include the default flow during restore

Flavio Leitner fbl at sysclose.org
Wed Sep 12 22:36:10 UTC 2018


On Wed, Sep 12, 2018 at 10:54:36AM -0700, Guru Shetty wrote:
> On Sun, 9 Sep 2018 at 05:20, Timothy Redaelli <tredaelli at redhat.com> wrote:
> 
> > Currently the default flow (actions=NORMAL) is present in the flow table
> > after
> > the flow table is restored also when the default flow is removed.
> >
> > This commit changes the behaviour of the "ovs-save save-flows" command to
> > use
> > "replace-flows" instead of "add-flows" to restore the flows. This is
> > needed in
> > order to always have the new flow table as it was before restoring it.
> >
> 
> Also, have you considered setting the bridge as "secure" to avoid adding
> NORMAL flow?
> Or is there is a use case to have it not be "secure"?

The issue is that there is no NORMAL flow when the flow table
is dumped. But then when ovs starts again, it is there by default
even after restoring the original flow table.

In the end you have the previous flow table plus the normal flow
which is unexpected.

The patch fix to restore the flow table as it was dumped.
HTH,
fbl


> 
> 
> >
> > Reported-by: Flavio Leitner <fbl at sysclose.org>
> > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1626096
> > Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
> > ---
> >  utilities/ovs-save | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/utilities/ovs-save b/utilities/ovs-save
> > index ea8fb6a45..2294583d6 100755
> > --- a/utilities/ovs-save
> > +++ b/utilities/ovs-save
> > @@ -121,7 +121,7 @@ save_flows () {
> >               cnt++;printf "{class="$1",type="$2",len="$3"}->"$4}'
> >          echo "'"
> >
> > -        printf "%s" "ovs-ofctl -O $ofp_version add-flows ${bridge} " \
> > +        printf "%s" "ovs-ofctl -O $ofp_version replace-flows ${bridge} " \
> >              "\"$workdir/$bridge.flows.dump\""
> >
> >          # If possible, use OpenFlow 1.4 atomic bundle transaction to add
> > flows
> > --
> > 2.17.1
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >

-- 
Flavio



More information about the dev mailing list