[ovs-dev] [PATCH v2] bundle: add symmetric_l3 hash method for multipath

Ben Pfaff blp at ovn.org
Tue Sep 18 08:33:00 UTC 2018


On Tue, Sep 11, 2018 at 11:59:36PM -0700, Martin Xu wrote:
> Add a symmetric_l3 hash method that uses both network destination
> address and network source address.
> 
> VMware-BZ: #2112940
> 
> Signed-off-by: Martin Xu <martinxu9.ovs at gmail.com>
> CC: Ben Pfaff <blp at ovn.org>

Thanks for the patch.  It looks OK to me.  I have a few comments.

I think that this should be mentioned in NEWS.

In ovs-ofctl.8.in, I don't think "Network" needs to be capitalized, in
two places.

In the tests directory, grepping for "symmetric", I see a number of
places where we test related features.  It would be wise to add similar
tests for the new hashing method.

Thanks,

Ben.


More information about the dev mailing list