[ovs-dev] [patch v4] conntrack: Add rcu support.
Ben Pfaff
blp at ovn.org
Thu Sep 27 18:10:08 UTC 2018
On Tue, Sep 18, 2018 at 01:22:50PM -0700, Darrell Ball wrote:
> Add in rcu support for conntrack. At the same time, the array of
> hmaps is replaced by a cmap. Using a single map also simplifies
> the handling of nat and allows the removal of the nat_conn map.
> There is still some cleanup to do and a few things to check. I'll
> probably split out into several patches later, as some cosmetic
> changes were made at the same time, like getting rid of the
> private conntrack structure contents exported outside of conntrack;
> these fields are made static to conntrack now.
>
> Signed-off-by: Darrell Ball <dlu998 at gmail.com>
Hi Darrell, thanks for the patch.
Can you add a sentence or two to the commit message, please, explaining
the motivation or the goal for the patch? It's not clear to me whether
this is a performance optimization, or a cleanup, or a fix for a race,
etc. This information helps review the patch and it also helps people
looking through the history tracking down a bug etc.
More information about the dev
mailing list