[ovs-dev] [ovs-dev, v2, 1/2] ovn-controller: Fix busy loop when sb disconnected.

[0-day Robot]

Bleep bloop.  Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 83 characters long (recommended limit is 79)
#97 FILE: ovn/controller/ovn-controller.c:735:
                    addr_sets_init(sbrec_address_set_table_get(ovnsb_idl_loop.idl),

WARNING: Line is 83 characters long (recommended limit is 79)
#132 FILE: ovn/controller/ovn-controller.c:767:
                            struct hmap flow_table = HMAP_INITIALIZER(&flow_table);

WARNING: Line is 81 characters long (recommended limit is 79)
#137 FILE: ovn/controller/ovn-controller.c:772:
                                sbrec_dhcp_options_table_get(ovnsb_idl_loop.idl),

WARNING: Line is 83 characters long (recommended limit is 79)
#138 FILE: ovn/controller/ovn-controller.c:773:
                                sbrec_dhcpv6_options_table_get(ovnsb_idl_loop.idl),

WARNING: Line is 81 characters long (recommended limit is 79)
#139 FILE: ovn/controller/ovn-controller.c:774:
                                sbrec_logical_flow_table_get(ovnsb_idl_loop.idl),

WARNING: Line is 80 characters long (recommended limit is 79)
#140 FILE: ovn/controller/ovn-controller.c:775:
                                sbrec_mac_binding_table_get(ovnsb_idl_loop.idl),

WARNING: Line is 80 characters long (recommended limit is 79)
#143 FILE: ovn/controller/ovn-controller.c:778:
                                &port_groups, &active_tunnels, &local_lport_ids,

WARNING: Line is 81 characters long (recommended limit is 79)
#150 FILE: ovn/controller/ovn-controller.c:785:
                                    ovsrec_interface_table_get(ovs_idl_loop.idl),

WARNING: Line is 82 characters long (recommended limit is 79)
#152 FILE: ovn/controller/ovn-controller.c:787:
                                    sbrec_sb_global_table_get(ovnsb_idl_loop.idl),

WARNING: Line is 81 characters long (recommended limit is 79)
#160 FILE: ovn/controller/ovn-controller.c:795:
                                sbrec_port_binding_table_get(ovnsb_idl_loop.idl),

WARNING: Line is 81 characters long (recommended limit is 79)
#171 FILE: ovn/controller/ovn-controller.c:806:
                                       sbrec_meter_table_get(ovnsb_idl_loop.idl),

WARNING: Line is 83 characters long (recommended limit is 79)
#221 FILE: ovn/controller/ovn-controller.c:824:
                        char *error = ofctrl_inject_pkt(br_int, pending_pkt.flow_s,

WARNING: Line is 82 characters long (recommended limit is 79)
#222 FILE: ovn/controller/ovn-controller.c:825:
                                                        &addr_sets, &port_groups);

WARNING: Line is 81 characters long (recommended limit is 79)
#224 FILE: ovn/controller/ovn-controller.c:827:
                            unixctl_command_reply_error(pending_pkt.conn, error);

Lines checked: 256, Warnings: 14, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot