[ovs-dev] [PATCH v2 1/2] netdev-linux: Add coverage counters for netdev_set_policing when ingress tc-offload

Pieter Jansen van Vuuren pieter.jansenvanvuuren at netronome.com
Tue Apr 9 08:10:41 UTC 2019


On 07/04/2019 16:10, Tonghao Zhang wrote:
> When enable tc-offload, we should add coverage counters for netdev_set_policing.
> 
> Fixes: e7f6ba220e10 ("lib/tc: add ingress ratelimiting support for tc-offload")
> Cc: Pieter Jansen van Vuuren <pieter.jansenvanvuuren at netronome.com>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue at gmail.com>
> ---
>  lib/netdev-linux.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index deedc69..0fce217 100644
> --- a/lib/netdev-linux.c
> +++ b/lib/netdev-linux.c
> @@ -2474,6 +2474,8 @@ netdev_linux_set_policing(struct netdev *netdev_,
>          goto out;
>      }
>  
> +    COVERAGE_INC(netdev_set_policing);
> +
>      /* Use matchall for policing when offloadling ovs with tc-flower. */
>      if (netdev_is_flow_api_enabled()) {
>          error = tc_del_matchall_policer(netdev_);
> @@ -2484,7 +2486,6 @@ netdev_linux_set_policing(struct netdev *netdev_,
>          return error;
>      }
>  
> -    COVERAGE_INC(netdev_set_policing);
>      /* Remove any existing ingress qdisc. */
>      error = tc_add_del_ingress_qdisc(ifindex, false, 0);
>      if (error) {
> 

Thank you.
Reviewed-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren at netronome.com>


More information about the dev mailing list