[ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign vport netdev functions.

[Aaron Conole]

0-day Robot <robot at bytheb.org> writes:

> Bleep bloop.  Greetings Ophir Munk, I am a robot and I have tried out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting.  See the details below.
>
>
> build:
...
> libtool: link: gcc -std=gnu99 -Wstrict-prototypes -Wall -Wextra
> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security
> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align
> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes
> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror
> -Werror -g -O2 -o utilities/ovs-testcontroller
> utilities/ovs-testcontroller.o lib/.libs/libopenvswitch.a -lcap-ng
> -lssl -lcrypto -lpthread -lrt -lm -lunbound
> lib/.libs/libopenvswitch.a(dpif-netdev.o): In function `dpif_netdev_port_add':
> /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/lib/dpif-netdev.c:1869:
> undefined reference to `netdev_rte_offloads_port_add'
> collect2: error: ld returned 1 exit status
> make[2]: *** [utilities/ovs-testcontroller] Error 1
> make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make: *** [all] Error 2

I guess you'll need to provide an implementation for the non-dpdk
builds.

I also suggest a different name than netdev_rte_offloads_port_add

rte comes from dpdk as an acronym for Run Time Environment.  Maybe even
just dropping the 'rte_' portion?

>
> Thanks,
> 0-day Robot
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev