[ovs-dev] [PATCH v3 3/6] ovn: Add a new OVN field icmp4.frag_mtu

Ben Pfaff blp at ovn.org
Thu Apr 18 21:56:58 UTC 2019


On Thu, Apr 18, 2019 at 02:55:58PM -0700, Ben Pfaff wrote:
> This calculation in pinctrl_handle_icmp() looks suspect to me.  Does it
> function properly if the packet is larger than about 576 bytes and the
> subtraction wraps around?
> 
> +            /* Calculate available room to include the original IP + data. */
> +            nh = dp_packet_l3(&packet);
> +            uint16_t room = 576 - (sizeof *eh + ntohs(nh->ip_tot_len));
> +            if (in_ip_len > room) {
> +                in_ip_len = room;
> +            }

Excuse me: the above is actually a comment for patch 4.


More information about the dev mailing list