[ovs-dev] [PATCH] travis: Fix checks skipping by sparse.

Ben Pfaff blp at ovn.org
Wed Apr 24 15:34:53 UTC 2019


On Wed, Apr 24, 2019 at 04:00:22PM +0300, Ilya Maximets wrote:
> Recent commit in "sparse" broke checking the OVS sources, because
> 'make' uses '-MD' flag to generate dependencies as a side effect
> within compilation commands, but "sparse" skips all the build commands
> that contains '-MD' and friends.
> Let's revert the bad commit as a workaround before installing "sparse"
> in TravisCI.
> 
> Additionally fixed a false-positive:
> ./lib/bitmap.h:64:29: error: shift too big (64) for type unsigned long
> 
> CC: Yi-Hung Wei <yihung.wei at gmail.com>
> Fixes: 879e8238dfdf ("travis: Update sparse git repo")
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>

Thanks.

If upstream sparse doesn't fix this in a reasonable amount of time, then
we should probably add a note to the installation guide mentioning this
fix, so that developers know to take advantage of it too.


More information about the dev mailing list