[ovs-dev] [PATCH v1 ovn] Containerize components
0-day Robot
robot at bytheb.org
Thu Aug 1 16:33:07 UTC 2019
Bleep bloop. Greetings Aliasgar Ginwala, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Aliasgar Ginwala <amginwal at gmail.com> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: aginwala <aginwala at ebay.com>
WARNING: Line has trailing whitespace
#44 FILE: Documentation/intro/install/general.rst:387:
For OVN central node, we dont need to load ovs kernel modules on host.
WARNING: Line has trailing whitespace
#85 FILE: Documentation/intro/install/general.rst:428:
Current ovn central components comes up in docker image in a standalone
WARNING: Line has trailing whitespace
#86 FILE: Documentation/intro/install/general.rst:429:
mode with protocol tcp.
WARNING: Line has trailing whitespace
#90 FILE: Documentation/intro/install/general.rst:433:
User can use any other base image for debian, e.g. u14.04, etc.
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#93 FILE: Documentation/intro/install/general.rst:436:
WARNING: Line has trailing whitespace
#103 FILE: Documentation/intro/install/general.rst:465:
Start ovsdb-server and ovs-vswitchd components as per
WARNING: Line has trailing whitespace
#119 FILE: Documentation/intro/install/general.rst:487:
When using ovn in container, exec to container to run above commands::
WARNING: Line is 86 characters long (recommended limit is 79)
#194 FILE: utilities/docker/create_ovn_dbs.sh:15:
ovsdb-tool create /etc/openvswitch/ovnnb_db.db /usr/share/openvswitch/ovn-nb.ovsschema
WARNING: Line is 86 characters long (recommended limit is 79)
#195 FILE: utilities/docker/create_ovn_dbs.sh:16:
ovsdb-tool create /etc/openvswitch/ovnsb_db.db /usr/share/openvswitch/ovn-sb.ovsschema
WARNING: Line is 99 characters long (recommended limit is 79)
#221 FILE: utilities/docker/debian/Dockerfile:20:
VOLUME ["/var/log/openvswitch", "/var/lib/openvswitch", "/var/run/openvswitch", "/etc/openvswitch"]
WARNING: Line is 88 characters long (recommended limit is 79)
#249 FILE: utilities/docker/debian/build.sh:21:
build_deps="apt-utils libelf-dev build-essential libssl-dev python python-six wget vim \
WARNING: Line has trailing whitespace
#250 FILE: utilities/docker/debian/build.sh:22:
gdb autoconf libtool git automake bzip2 debhelper dh-autoreconf openssl"
Lines checked: 341, Warnings: 14, Errors: 1
Please check this out. If you feel there has been an error, please email aconole at bytheb.org
Thanks,
0-day Robot
More information about the dev
mailing list