[ovs-dev] [PATCH] OVS: Containerize components

0-day Robot robot at bytheb.org
Thu Aug 1 16:42:30 UTC 2019


Bleep bloop.  Greetings Aliasgar Ginwala, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Aliasgar Ginwala <amginwal at gmail.com> needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: aginwala <aginwala at ebay.com>
WARNING: Line has trailing whitespace
#41 FILE: Documentation/intro/install/general.rst:509:
For ovs vswitchd, we need to load ovs kernel modules on host. 

WARNING: Line has trailing whitespace
#83 FILE: Documentation/intro/install/general.rst:551:
    User can use any other base image for debian, e.g. u14.04, etc. 

WARNING: Line has trailing whitespace
#94 FILE: Documentation/intro/install/general.rst:569:
When using ovs in container, exec to container to run above commands:: 

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#115 FILE: Documentation/intro/install/general.rst:652:
   

WARNING: Line is 83 characters long (recommended limit is 79)
#187 FILE: utilities/docker/create_ovs_db.sh:15:
ovsdb-tool create /etc/openvswitch/conf.db /usr/share/openvswitch/vswitch.ovsschema

WARNING: Line is 99 characters long (recommended limit is 79)
#212 FILE: utilities/docker/debian/Dockerfile:18:
VOLUME ["/var/log/openvswitch", "/var/lib/openvswitch", "/var/run/openvswitch", "/etc/openvswitch"]

WARNING: Line is 88 characters long (recommended limit is 79)
#240 FILE: utilities/docker/debian/build-kernel-modules.sh:21:
build_deps="apt-utils libelf-dev build-essential libssl-dev python python-six wget vim \

WARNING: Line has trailing whitespace
#241 FILE: utilities/docker/debian/build-kernel-modules.sh:22:
gdb autoconf libtool git automake bzip2 debhelper dh-autoreconf openssl" 

Lines checked: 324, Warnings: 10, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot


More information about the dev mailing list