[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function

Damijan Skvarc damjan.skvarc at gmail.com
Fri Aug 2 06:26:37 UTC 2019


Done!
Thanks for review.

On Wed, Jul 31, 2019 at 6:40 PM Mark Michelson <mmichels at redhat.com> wrote:

> I've pushed this to OVN master. Damijan, could you post a backport patch
> for OVS 2.12, please? Thanks!
>
> On 7/31/19 9:17 AM, Mark Michelson wrote:
> > Thanks for the fix!
> > Acked-by: Mark Michelson <mmichels at redhat.com>
> >
> > This will need a backport to the OVS 2.12 branch as well.
> >
> > On 7/31/19 6:43 AM, Damijan Skvarc wrote:
> >> Within this function actions & match dynamic strings are used as helper
> >> variables for adding entries into logical flow table. Variables are
> >> used several times in order to optimize number of memory allocations,
> >> however at the end memory was forgotten to be deallocated.
> >>
> >> Signed-off-by: Damijan Skvarc <damjan.skvarc at gmail.com>
> >> ---
> >>   northd/ovn-northd.c | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> >> index 979dea4..8588961 100644
> >> --- a/northd/ovn-northd.c
> >> +++ b/northd/ovn-northd.c
> >> @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows,
> >> const struct ovn_port *op)
> >>               ds_clear(&actions);
> >>           }
> >>       }
> >> +    ds_destroy(&match);
> >> +    ds_destroy(&actions);
> >>   }
> >>   static void
> >>
> >
>
>


More information about the dev mailing list