[ovs-dev] [PATCH] OVN: fix L4 default lb proto reported by ovn-nbctl

Dumitru Ceara dceara at redhat.com
Fri Aug 2 12:40:20 UTC 2019


On Thu, Aug 1, 2019 at 7:40 PM Lorenzo Bianconi
<lorenzo.bianconi at redhat.com> wrote:
>
> If no protocol is specified defining a load balancing rule TCP is
> selected as default but ovn-nbctl lb-list reports 'tcp/udp'.
> Fix it reporting 'tcp' in this case
>
> Fixes: e2bfcad6cbb0 ("ovn-nbctl: Add LB commands")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi at redhat.com>

Looks good to me.
Acked-by: Dumitru Ceara <dceara at redhat.com>

> ---
>  ovn/utilities/ovn-nbctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
> index 98a8faa0b..7a38b2bf7 100644
> --- a/ovn/utilities/ovn-nbctl.c
> +++ b/ovn/utilities/ovn-nbctl.c
> @@ -2864,7 +2864,7 @@ lb_info_add_smap(const struct nbrec_load_balancer *lb,
>                  continue;
>              }
>
> -            char *protocol = ss_get_port(&ss) ? lb->protocol : "tcp/udp";
> +            char *protocol = ss_get_port(&ss) ? lb->protocol : "tcp";
>              i == 0 ? ds_put_format(&val,
>                          UUID_FMT "    %-20.16s%-11.7s%-*.*s%s",
>                          UUID_ARGS(&lb->header_.uuid),
> --
> 2.21.0
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list