[ovs-dev] [PATCH 02/12] vswitchd: Add datapath, CT_Zone, and CT_Timeout_Policy tables.

Justin Pettit jpettit at ovn.org
Fri Aug 2 18:21:49 UTC 2019


> On Jul 26, 2019, at 8:11 AM, William Tu <u9012063 at gmail.com> wrote:
> 
> On Thu, Jul 25, 2019 at 04:24:04PM -0700, Yi-Hung Wei wrote:
>> 
>> +         "type": {"key": "string", "value": "string",
>> +                  "min": 0, "max": "unlimited"}}},
>> +       "indexes": [["timeouts"]]},
> 
> Just to let you know, this is a little different than your
> original patch. I made the timeouts column to be unique using
> "indexes" above. And update the cksum.

Hi, William.  As we discussed off-line, I don't think we want to do this, since it could complicate user interactions.  It requires that user be aware of whether they introduce two timeout policies that are identical, which could be burdensome if they're taking user input, which could start off with two different policies that become the same later.  The controller would need to keep track of that situation.  I think it's better if ovs-vswitchd keeps track of whether two timeout policies are identical for de-duplication if we want that optimization.

I think Yi-Hung's v2 removed this.

Thanks,

--Justin




More information about the dev mailing list