[ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

[Justin Pettit]

> On Aug 5, 2019, at 8:07 PM, Darrell Ball <dlu998 at gmail.com> wrote:
> 
> On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei <yihung.wei at gmail.com> wrote:
> 
>> +struct ct_timeout_policy {
>> +    struct uuid uuid;
>> +    unsigned int last_used_seqno;
>> +    struct ct_dpif_timeout_policy cdtp;
>> +    struct cmap_node node;          /* Element in struct dpif_backer's
>> +                                     * "ct_tps" cmap. */
>> 
> 
> 
> This looks like a layering violation
> should be in dpif-netlink or netlink-conntrack for kernel side

Hi, Darrell.  As I mentioned in my code review, I had my own concerns about layering, but mine were from the top-down.  Yi-Hung and I didn't understand your concern here, since these seem to be structures that would be useful regardless of the implementation.  Can you explain a bit more about your layering concerns?

Thanks,

--Justin