[ovs-dev] [PATCH 1/1] ovn-openstack.rst: Miscelaneous fixes.

0-day Robot robot at bytheb.org
Wed Aug 7 23:17:18 UTC 2019


Bleep bloop.  Greetings Flavio Fernandes, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 99 characters long (recommended limit is 79)
#37 FILE: Documentation/tutorials/ovn-openstack.rst:71:
   https://github.com/openstack/devstack/blob/master/doc/source/guides/devstack-with-nested-kvm.rst

WARNING: Line is 80 characters long (recommended limit is 79)
#51 FILE: Documentation/tutorials/ovn-openstack.rst:183:
      to you, edit ``local.conf`` and explicitly provide it (X marks the spot)::

WARNING: Line has non-spaces leading whitespace
#80 FILE: Documentation/tutorials/ovn-openstack.rst:1019:
	 sudo ovs-dpctl dump-flows >> /tmp/flows.txt ; \

WARNING: Line has non-spaces leading whitespace
#81 FILE: Documentation/tutorials/ovn-openstack.rst:1020:
	 sleep 0.1 ; done

WARNING: Line is 103 characters long (recommended limit is 79)
#135 FILE: Documentation/tutorials/ovn-openstack.rst:1772:
    $ N1SUBNET4_MAC=$(ovn-nbctl --bare --columns=mac find logical_router_port networks=\"10.1.1.1/24\")

WARNING: Line is 197 characters long (recommended limit is 79)
#140 FILE: Documentation/tutorials/ovn-openstack.rst:1776:
    $ ovn-trace --ct new --ct new --minimal n1 'inport == "ap" && eth.src == '$AP_MAC' && eth.dst == '$N1SUBNET4_MAC' && ip4.src == 10.1.1.5 && ip4.dst == 10.1.2.7 && ip.ttl == 64 && tcp.dst == 22'

WARNING: Line is 197 characters long (recommended limit is 79)
#149 FILE: Documentation/tutorials/ovn-openstack.rst:1791:
    $ ovn-trace --ct new --ct new --minimal n1 'inport == "ap" && eth.src == '$AP_MAC' && eth.dst == '$N1SUBNET4_MAC' && ip4.src == 10.1.1.5 && ip4.dst == 10.1.2.7 && ip.ttl == 64 && tcp.dst == 23'

WARNING: Line is 205 characters long (recommended limit is 79)
#158 FILE: Documentation/tutorials/ovn-openstack.rst:1804:
    $ ovn-trace --ct est,rpl --ct est,rpl --minimal n1 'inport == "ap" && eth.src == '$AP_MAC' && eth.dst == '$N1SUBNET4_MAC' && ip4.src == 10.1.1.5 && ip4.dst == 10.1.2.7 && ip.ttl == 64 && tcp.dst == 23'

Lines checked: 164, Warnings: 8, Errors: 0


build:
    -e 's,[@]PYTHON[@],/bin/python2,g' \
    -e 's,[@]RUNDIR[@],/usr/local/var/run/openvswitch,g' \
    -e 's,[@]VERSION[@],2.12.90,g' \
    -e 's,[@]localstatedir[@],/usr/local/var,g' \
    -e 's,[@]pkgdatadir[@],/usr/local/share/openvswitch,g' \
    -e 's,[@]sysconfdir[@],/usr/local/etc,g' \
    -e 's,[@]bindir[@],/usr/local/bin,g' \
    -e 's,[@]sbindir[@],/usr/local/sbin,g' \
    -e 's,[@]abs_builddir[@],/var/lib/jenkins/jobs/upstream_build_from_pw/workspace,g' \
    -e 's,[@]abs_top_srcdir[@],/var/lib/jenkins/jobs/upstream_build_from_pw/workspace,g' \
  > rhel/ovn-fedora.spec.tmp
mv rhel/ovn-fedora.spec.tmp rhel/ovn-fedora.spec
(printf '\043 Generated automatically -- do not modify!    -*- buffer-read-only: t -*-\n' && sed -e 's,[@]VERSION[@],2.12.90,g') \
	< ./xenserver/openvswitch-xen.spec.in > openvswitch-xen.spec.tmp || exit 1; \
if cmp -s openvswitch-xen.spec.tmp xenserver/openvswitch-xen.spec; then touch xenserver/openvswitch-xen.spec; rm openvswitch-xen.spec.tmp; else mv openvswitch-xen.spec.tmp xenserver/openvswitch-xen.spec; fi
make[3]: Entering directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/datapath'
make[3]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/datapath'
Documentation/tutorials/ovn-openstack.rst
See above for files that use tabs for indentation.
Please use spaces instead.
make[2]: *** [check-tabs] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot


More information about the dev mailing list